Feature Request #165

Do not query google if currency conversion is not necessary.

Added by Oscar Bajner over 2 years ago. Updated over 2 years ago.

Status:Closed Start:08/08/2009
Priority:Normal Due date:
Assigned to:Jeremy Bush % Done:

100%
Category:Invoices
Target version:0.7.3
Resolution:fixed

Description

Currently the currency helper always queries google to perform a
currency conversion, even if the "from" currency is the same
as the "to" currency.

Setup: Windows Vista, Apache 2.2.6, PHP 5.2.6, MySQL 5.1.0, argentum svn trunk

Proposed New Feature: Patch attached. (patch06.diff)
in ./helpers/currency.php check the "from" and "to" currencies, if the same,
do not query google, but simply return the amount.

patch06.diff (486 Bytes) Oscar Bajner, 08/08/2009 11:52 am

Associated revisions

Revision 260
Added by Jeremy Bush over 2 years ago

Fixing #165.

History

#1
Updated by Jeremy Bush over 2 years ago

  • Target version set to 0.7.3

#2
Updated by Jeremy Bush over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset r259.

#3
Updated by Jeremy Bush over 2 years ago

  • Resolution set to fixed

Also available in: Atom PDF